-
Notifications
You must be signed in to change notification settings - Fork 637
🌱 Drop unused conversion functions #5740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Drop unused conversion functions #5740
Conversation
d290f2c to
f9f767e
Compare
|
/assign @damdo @nrb @richardcase |
|
/assign @AndiDog |
|
/lgtm Waiting for green build |
|
LGTM label has been added. Git tree hash: 6b4031ad5f30ad33ad021638c9d53a241fac122e
|
|
If the CI passes feel free to unhold /hold From my side: /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Failure is a flake /test pull-cluster-api-provider-aws-e2e-blocking |
|
/test pull-cluster-api-provider-aws-e2e-blocking |
1 similar comment
|
/test pull-cluster-api-provider-aws-e2e-blocking |
|
Great, everything is green /unhold |
|
/cherry-pick release-2.9 |
|
@chrischdi: new pull request created: #5743 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes unused conversion functions in favor of #5739
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: